Repository navigation
replace !persisted with new_record? and !empty? with any? - #3091
Merged
Merged
Conversation
italomatos
force-pushed
the
improve-syntax
branch
from
August 17, 2022 00:11
d04b5f8 to
bf06a4c
Compare
italomatos
force-pushed
the
improve-syntax
branch
from
August 19, 2022 22:34
889edee to
eb27663
Compare
edwinthinks
approved these changes
Aug 20, 2022
edwinthinks
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. This is much cleaner thank you @italomatos
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR has the goal to improve code syntax, using some tips of clean code book
!something.empty?withsomething.any?!something.new_record?withsomething.persisted?!something.persisted?withsomething.new_record?